Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kots pull should default to writing to current working directory instead of home directory #1860

Open
gabegorelick opened this issue May 27, 2021 · 0 comments

Comments

@gabegorelick
Copy link

It's not clear from the docs what directory kots pull will write to. https://kots.io/kots-cli/pull/ says that it defaults to /path/, which can't be right (surely it's not writing to the root of your file system).

kots pull --help says it writes to your home directory:

--rootdir string root directory that will be used to write the yaml to (default "/Users/gabe")

In practice, this appears to be what it does (create a directory under $HOME). But it would be better if it instead wrote to the current working directory. The current behavior is unexpected (much more common for tools to write to current directory rather than home directory), and somewhat dangerous (it will overwrite any files that happen to live at ~/$REPLICATED_APP/{base,overlays,skippedFiles,upstream}).

To its credit, kots pull does tell you exactly where it wrote its files after the fact ("Kubernetes application files created in ..."). So that helps somewhat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant