You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
, but I'm opening an issue rather than a PR since I realize there's a bit of a design choice here -- parsing a label_name there would make it work with taking an implicit global label from above, and i'm not entirely sure if that behavior would be preferable or if it should only accept fully qualified labels
labelfoo:
"hello world""aaaaaaa"label .bar:
"abcdefg"# this one already workstestcase with_global_label:
click until label foo
# = Until(left=..., right=Label(name="foo"))# this one doesn't currently work but definitely seems like it shouldtestcase with_qualified_local_label:
click until label foo.bar
# = Until(left=..., right=Label(name="foo.bar"))# should this one work?testcase with_unqualified_local_label:
click until label .bar# = Until(left=..., right=Label(name="foo.bar"))
Footnotes
based on some quick print debugging it looks like renpy.test.testexecution.labels already contains strings for local labels (e.g. "foo.bar") too, and that's the only place renpy.test.testast.Label checks, so testast.Label(name="foo.bar") should just work ↩
The text was updated successfully, but these errors were encountered:
the
label
statement in atestcase
currently only works with global labels, since it doesn't accept a dottedfoo.bar
label.afaict, the fix should be as simple as1 changing
l.name
to e.g.l.label_name
here:renpy/renpy/test/testparser.py
Lines 117 to 120 in b7f4812
, but I'm opening an issue rather than a PR since I realize there's a bit of a design choice here -- parsing a
label_name
there would make it work with taking an implicit global label from above, and i'm not entirely sure if that behavior would be preferable or if it should only accept fully qualified labelsFootnotes
based on some quick print debugging it looks like
renpy.test.testexecution.labels
already contains strings for local labels (e.g."foo.bar"
) too, and that's the only placerenpy.test.testast.Label
checks, sotestast.Label(name="foo.bar")
should just work ↩The text was updated successfully, but these errors were encountered: