Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not apply what_suffix if dialogue will be extended #5394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: do not apply what_suffix if dialogue will be extended #5394

wants to merge 1 commit into from

Conversation

JellyBlack
Copy link

fix #5370

@Gouvernathor
Copy link
Member

I disagree with the implementation (which does not treat prefix and suffix symmetrically), and also with the base idea but I will write that in the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What_suffix should not be applied if dialogue will be extended.
2 participants
@JellyBlack @Gouvernathor