Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What_suffix should not be applied if dialogue will be extended. #5370

Open
renpytom opened this issue Feb 19, 2024 · 5 comments · May be fixed by #5394
Open

What_suffix should not be applied if dialogue will be extended. #5370

renpytom opened this issue Feb 19, 2024 · 5 comments · May be fixed by #5394
Labels
duration - hour Resolving this is estimated to an hour of development enhancement A proposed or requested enhancement or improvement to renpy's features.

Comments

@renpytom
Copy link
Member

No description provided.

@renpytom renpytom added enhancement A proposed or requested enhancement or improvement to renpy's features. duration - hour Resolving this is estimated to an hour of development labels Feb 19, 2024
@Jaybe-Games
Copy link

Great

@Gouvernathor
Copy link
Member

Gouvernathor commented Mar 6, 2024

Given the current code :

eileen "Hey, "
extend "you"

The current implem displays the following

(prefix)Hey, (suffix)
(prefix)Hey, you(suffix)

Which I believe is the best, correct behavior. Any change would surprise creators and I don't think a majority would like the alternative better.

@Jaybe-Games
Copy link

Given the current code :

eileen "Hey, "
extend "you"

The current implem displays the following

(prefix)Hey, (suffix)
(prefix)Hey, you(suffix)

Which I believe is the best, correct behavior. Any change would surprise creators and I don't think a majority would like the alternative better.

Since I use quotationmarks

for me this is the best

(prefix)Hey,
(prefix)Hey, you(suffix)

It looks goofy to have quotationmarks moving around in text so it should only apply at the last extend.
Maybe having an variable to switch the mode between old and my idea.

@JellyBlack
Copy link

consider the following script:

$ flag = True
s 'sentence 1'
if flag:
    extend 'sentence 2'

It's hard to tell whether "sencence 1" will be extended or not, especially if we don't know flag will be True or False. Extremely, let flag be random:

s 'sentence 1'
python:
    import random
    flag = random.randint(0, 1)
if flag:
    extend 'sentence 2'

when "sentence 1" is shown, we definitely don't know whether "sencence 2" will show or not. flag is determined at runtime, so JIT compilation or something else won't help.

@Gouvernathor
Copy link
Member

We do have an extend-predicting system in place, but the example above shows how unexpectable and magic it can be, so I don't think that's a sound solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duration - hour Resolving this is estimated to an hour of development enhancement A proposed or requested enhancement or improvement to renpy's features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants