Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content type not returned properly for xml files #30

Open
jefimm opened this issue Sep 17, 2020 · 3 comments
Open

content type not returned properly for xml files #30

jefimm opened this issue Sep 17, 2020 · 3 comments

Comments

@jefimm
Copy link
Contributor

jefimm commented Sep 17, 2020

The https://github.com/renaudcerrato/appengine-maven-repository/blob/master/src/main/java/repo/resource/RepositoryResource.java#L104 does not work properly for the *.xml files as the GCP does not set the content type for the XML and the *.xml files are returned as 'application/octet-stream'
This causes issue with some tools that rely on the content type

@renaudcerrato
Copy link
Owner

renaudcerrato commented Sep 23, 2020

Mmmm... It sounds like your application is not setting the Content-Type header : the mime is taken from it. Can you check ?

https://github.com/renaudcerrato/appengine-maven-repository/blob/master/src/main/java/repo/resource/RepositoryResource.java#L135

@jefimm
Copy link
Contributor Author

jefimm commented Sep 23, 2020

might be, we are using https://leiningen.org

@renaudcerrato
Copy link
Owner

I'd suggest to report a bug to that tool, but we may also add some basic mime-type detection based on file extension. PR are still welcome ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants