Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to properly handle bad videos in OffthreadVideo without crashing #3277

Open
JonnyBurger opened this issue Dec 19, 2023 · 0 comments
Open

Comments

@JonnyBurger
Copy link
Member

From message posted on Discord by adam.pzz

Hello.

When I render a video with Lambda, more specifically, a .mp4 without video stream, the render crashes and I get the following error :

I'm using Remotion v4.0.36.

Stopping Lambda function because error occurred while rendering chunk 46:\n   Error: Compositor error: No video stream found in input file\n      0: <compositor::errors::ErrorWithBacktrace as core::convert::From<&str>>::from\n      1: compositor::opened_stream::open_stream\n      2: compositor::opened_video_manager::OpenedVideoManager::get_video\n      3: compositor::commands::execute_command\n      4: rayon_core::thread_pool::ThreadPool::install::{{closure}}\n      5: <rayon_core::job::StackJob<L,F,R> as rayon_core::job::Job>::execute\n      6: rayon_core::registry::WorkerThread::wait_until_cold\n      7: std::sys_common::backtrace::__rust_begin_short_backtrace\n      8: core::ops::function::FnOnce::call_once{{vtable.shim}}\n      9: std::sys::unix::thread::Thread::new::thread_start\n     10: start_thread\n     11: thread_start\n   \n       at onMessage (/var/task/index.js:42535:41)\n       at processInput (/var/task/index.js:42593:9)\n       at processInput (/var/task/index.js:42596:9)\n       at Socket.<anonymous> (/var/task/index.js:42613:9)\n       at Socket.emit (node:events:513:28)\n       at addChunk (node:internal/streams/readable:324:12)\n       at readableAddChunk (node:internal/streams/readable:297:9)\n       at Readable.push (node:internal/streams/readable:234:10)\n       at Pipe.onStreamRead (node:internal/stream_base_commons:190:23)

I'm displaying this video using :

<OffthreadVideo
  volume={1}
  muted={false}
  src={sequenceSrc}
  startFrom={mediaStart * fps}
  endAt={mediaEnd * fps + 1}
  onError={(e) => console.log(e)}
/>

While I completely understand this error, I would like to know if there is a reliable way to prevent this error from happening before launching the Remotion lambda process.

@JonnyBurger JonnyBurger changed the title Crash when rendering video without video stream in Lambda with Remotion v4.0.36. Ability to properly handle bad videos in OffthreadVideo without crashing Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant