Unit test fails using Postgres

[mchurchward]

A unit test that works with MySQL fails under Postgres.
MySQL version - https://travis-ci.org/POETGroup/moodle-report_ncccscensus/jobs/164651761#L701
Postgres version - https://travis-ci.org/POETGroup/moodle-report_ncccscensus/jobs/164651760#L701

This may be related to #1 ?

[mchurchward]

This is not related to issue #1. The problem is that the unit test depends on the order of courses returned from 'report_ncccscensus_get_courses'. It is presuming they are returned in order of "id" but the function does not specify an order.
I believe the test is written incorrectly and should not depend on the order.

[tbannister]

That's pretty much my conclusion. I found the same problem on Friday, and am fixing it today.

[mchurchward]

Don't worry. I just fixed it. I'll supply the pull request momentarily.

[mchurchward]

This pull fixes this issue = PoetOS@3d99414
It also fixes some coding guideline issues.
I have to figure out how to change the basefork of POET's fork now.
This pull is off of the MOODLE_31_STABLE branch.