Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All users can se the Grade Me block #77

Open
cdipe opened this issue Sep 1, 2023 · 7 comments
Open

All users can se the Grade Me block #77

cdipe opened this issue Sep 1, 2023 · 7 comments

Comments

@cdipe
Copy link

cdipe commented Sep 1, 2023

The Grade me block should be visible to graders only.

Moodle 4.1.5

@gemguardian
Copy link

@cdipe I have a 4.1.5 site and the Grade Me block is only visiable to grade and not students on my Moodle.

@cdipe
Copy link
Author

cdipe commented Sep 4, 2023

@gemguardian, when I add the Grade Me block to a course, the permissions settings looks like this. Every role in the system gets added (the yellow marker are our different student roles:
image

And, when logged in as a Student (not "Log in as", but with a proper student account):

image

What can be wrong... I haven't found any role permissions regarding viewing the Grade Me block (only adding the block, and both those are set to Prevent)

We use Moodle 4.1.5+ (Build: 20230818) and Grade Me 2022112800

@jprovasnik
Copy link

jprovasnik commented Sep 4, 2023

Same in my Moodle instance. It goes away when I remove the authenticated user ability to view, which comes by default at the site level because authenticated users can view blocks in general. If I remove that at the site level, then it messes up my authenticated users view of blocks on the Moodle dashboard. But if there is a better / more proper way to handle this let me know!

@gemguardian
Copy link

strange. I just installed the plugin, did not alter any of the roles/premission to make it not show to students. Meaning it might be controlled by some other premission .

image

@danmarsden
Copy link

it looks like the PR #76 might fix this.

@cdipe
Copy link
Author

cdipe commented Sep 6, 2023

@danmarsden that's excellent, and as I understand the comment there, "This branch has no conflicts with the base branch", it seem to be ready for merge?

@danmarsden
Copy link

@logan-reynolds - looks like you've been the most recently active dev in the repo - any chance you could review #76 and merge it in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants