Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port make-frame-visible #1485

Open
brotzeit opened this issue May 8, 2019 · 1 comment
Open

Port make-frame-visible #1485

brotzeit opened this issue May 8, 2019 · 1 comment
Labels
Active PR There is a PR that resolves this issue. good first issue

Comments

@brotzeit
Copy link
Member

brotzeit commented May 8, 2019

DEFUN ("make-frame-visible", Fmake_frame_visible, Smake_frame_visible,
       0, 1, "",
       doc: /* Make the frame FRAME visible (assuming it is an X window).
If omitted, FRAME defaults to the currently selected frame.  */)
  (Lisp_Object frame)
{
  struct frame *f = decode_live_frame (frame);

  /* I think this should be done with a hook.  */
#ifdef HAVE_WINDOW_SYSTEM
  if (FRAME_WINDOW_P (f))
    x_make_frame_visible (f);
#endif

  make_frame_visible_1 (f->root_window);

  /* Make menu bar update for the Buffers and Frames menus.  */
  /* windows_or_buffers_changed = 15; FIXME: Why?  */

  XSETFRAME (frame, f);
  return frame;
}
@agraven agraven added this to To do in Porting efforts via automation May 16, 2019
@benreyn
Copy link

benreyn commented Aug 5, 2019

Id love to take a crack at porting this function If its not already claimed

Edit: looks like there is an open PR for this at #1526

@shaleh shaleh added the Active PR There is a PR that resolves this issue. label Aug 5, 2019
@agraven agraven moved this from To do to In progress in Porting efforts Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Active PR There is a PR that resolves this issue. good first issue
Projects
Porting efforts
  
In progress
Development

No branches or pull requests

3 participants