Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player not resuming when the current file fully load #7

Open
ubugnu opened this issue Oct 31, 2015 · 1 comment
Open

Player not resuming when the current file fully load #7

ubugnu opened this issue Oct 31, 2015 · 1 comment

Comments

@ubugnu
Copy link

ubugnu commented Oct 31, 2015

Whenever the play arrives to a limit where the current loaded file has not finished loading, it stops and doesn't resume. I tried tweaking with this:
if(!player.isPlaying()) player.play();
when the loading has finished, but it seems to repeat some tracks and even merge two playings

@wwoast
Copy link
Contributor

wwoast commented Apr 17, 2016

I've witnessed this problem of merging two songs before the first is finished. It seems to happen more often when the browser XHR thread is contending with other browser activity, or when the server is network-pegged. It also seems to happen more with Firefox than Chrome.

The fundamental issue here is that that song sections need to be reloaded in the face of error events on the XHR request. https://gist.github.com/mojaray2k/6619426 shows how you can grab file size for a completed XHR download, but Gapless would need a request manager to process and manage state for any errors that come up during the XHR download attempt, so it could retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants