New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New refgenconf requires python 3.8 #144

Open

nsheff opened this issue Oct 3, 2022 · 1 comment

Contributor

nsheff commented Oct 3, 2022

refgenconf/recipe.py:3: in <module>
    from functools import cached_property
E   ImportError: cannot import name 'cached_property' from 'functools' (/opt/hostedtoolcache/Python/3.7.14/x64/lib/python3.7/functools.py)

refgenconf/refgenconf/recipe.py

Line 3 in 3f2ea03

from functools import cached_property

@stolarczyk Were you intending to make refgenconf depend on Python 3.8?

Or do you think of this as an optional thing that we should take out until 3.7 is deprecated?

The text was updated successfully, but these errors were encountered:

nsheff added a commit that referenced this issue


          temporarily stop testing 3.7. See #144

807fd2d

Contributor

stolarczyk commented Oct 4, 2022 •

edited

hmmm.. I don't remember what my intention was. But what you can do is:

drop py3.7 support
remove cached_property decorators to keep py3.7 support
use @property in conjunction with @functools.lru_cache to keep py3.7 support

Since memoization is a "nice to have" feature I'd likely go for option 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment