Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get ASDs.json (if missing) on any asset pull #117

Open
stolarczyk opened this issue Mar 8, 2021 · 3 comments
Open

get ASDs.json (if missing) on any asset pull #117

stolarczyk opened this issue Mar 8, 2021 · 3 comments
Labels
enhancement New feature or request
Projects

Comments

@stolarczyk
Copy link
Contributor

stolarczyk commented Mar 8, 2021

in case of refgenie pull <genome>/<fasta_child>, only the genome digest is fixed (the ASDs file is missing)
so this genome can't be compared if the fasta was not built or pulled prior to this
the fasta asset specifically has to be pulled or built to get the ASDs

I suppose it wouldn't be hard to make pull include the ASD since it lives at the genome level and not in the fasta asset.

@stolarczyk stolarczyk added the enhancement New feature or request label Mar 8, 2021
@stolarczyk
Copy link
Contributor Author

stolarczyk commented Mar 9, 2021

ASDs.json files are only created when fasta asset is present because they are simply not served by refgenieserver. We don't have a concept of serving files that are not assets.

This shortcoming could be resolved by getting these genome metadata from a seqcol server, which doesn't exist yet.

@nsheff nsheff added this to Seqcol identifiers in Refgenie Mar 16, 2021
@nsheff
Copy link
Contributor

nsheff commented Nov 2, 2021

@stolarczyk is this resolved now that the server does server those ASDs with an endpoint?

@stolarczyk
Copy link
Contributor Author

now that the server does server those ASDs with an endpoint?

are you referring to seqcol server? refgenieserver does not serve them as far as I remember

Either way, I don't think it's solved yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Refgenie
Seqcol identifiers
Development

No branches or pull requests

2 participants