Skip to content
This repository has been archived by the owner on Apr 2, 2023. It is now read-only.

Use different example sentences #5

Open
reeseovine opened this issue Aug 30, 2020 · 2 comments
Open

Use different example sentences #5

reeseovine opened this issue Aug 30, 2020 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@reeseovine
Copy link
Owner

Finding a different set of sentences will help differentiate this module from pronoun.is. Also "Frisbee" is a trademark so we should avoid it.

Suggestions are welcome.

@reeseovine reeseovine added enhancement New feature or request help wanted Extra attention is needed labels Aug 30, 2020
@michaeljoelt
Copy link

I haven't looked in to your code yet, but how are you storing these? Could each "sentence type" be broken up in to an array with multiple examples, and then a random example from each could be displayed each time? Like:

const sentenceSubject = ["They went to the park.","They danced the night away.","Did they finish the assignment?"]
const sentenceObject = ["I went with them.","I've been thinking about them.","I told them the plan."]
const sentenceDeterminer = ["They brought their football.","They rode their bike here.","Their haircut looks amazing!"]
const sentencePossessive = ["At least I think it was theirs.","Were these old shoes theirs?","Sorry, I didn't know this was theirs."]
const sentenceReflexive = ["They threw the football to themself.","Did they come up with that themself?","Did they make this by themself?"]

Also, the "Their haircut looks amazing" example made me think about how it would be awesome to try to include a bunch of compliments in these :D

@reeseovine
Copy link
Owner Author

@michaeljoelt that's a great suggestion! i'll look into it at some point.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants