Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React 17 #4721

Open
nksfrank opened this issue Apr 8, 2021 · 7 comments
Open

Support React 17 #4721

nksfrank opened this issue Apr 8, 2021 · 7 comments
Labels

Comments

@nksfrank
Copy link

nksfrank commented Apr 8, 2021

Support React 17

React v17 has been released and is stable with no major breaking changes from v16.

Problem

Our project is currently stuck at React v16 because this package's peer dependency to react is locked to ^16.4.2. Blocking us from upgrading out of v16.
image

Expected behavior

I'm suggesting we add v17 to the peer dependencies: react: >=16.4.2 || ~17.0.
So that we are able to move our projects to React 17

@erwanriou
Copy link

+1 too lazy to pass to final form yet, and i rather stop doing npm i --force all the time :p

@rkhunt007
Copy link

What is the solution for now? npm i --force?

@erwanriou
Copy link

I do that in docker to fix the issue.
You can also manually format your package-lock, but carefully.

@mikkpokk
Copy link

Installing package is one thing, it's possible with a yarn or using flags --force / --legacy-peer-deps with a npm. Bigger problem is that package is not fixed to accept fixes that made for React 16.8 - 17. It's time to drop deprecated lifecycle methods.

Editing package requirement doesn't fix the problem.

@erwanriou
Copy link

at the end i made the migration to react-final-form that is way much better. Its a little work but it's quite compatible and the whole everything seems faster.

@sanex3339
Copy link
Contributor

sanex3339 commented Jul 19, 2021

The PR with partial rewrite of UNSAFE methods
#4741

need help to rewrite 4 remaining methods

@kimyu92
Copy link

kimyu92 commented Apr 6, 2023

This issue has been resolved with v8.3.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants