Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

submap sub map should maintain properties of parent map #235

Open
nathanmarz opened this issue Nov 13, 2017 · 0 comments
Open

submap sub map should maintain properties of parent map #235

nathanmarz opened this issue Nov 13, 2017 · 0 comments
Labels
enhancement

Comments

@nathanmarz
Copy link
Collaborator

It would be intuitive for a "sub map" to have the same properties as the parent map. Currently it uses select-keys which always returns an unsorted map. It should be easy to make an alternative implementation of select-keys for this navigator. submap! should also be updated.
jeff303 added a commit to jeff303/specter that referenced this issue Aug 21, 2020
@jeff303
redplanetlabs#235 - submap sub map should maintain properties of pa…
1de62b7 
…rent map

WORK IN PROGRESS

TODO: check if additional map types need support, implement and test submap! nav

Adding new SubMap protocol to handle the different implementations of key selection (including one that maintains order to be used for sorted-map)

Adding test to ensure order preserved for a large map
jeff303 added a commit to jeff303/specter that referenced this issue Sep 16, 2020
@jeff303
submap sub map should maintain properties of parent map redplanetla…
ed2cfc8 
…bs#235

TODO: figure out how to handle transients (i.e. submap!)

Adding new SubMap protocol to handle the different implementations of key selection (including one that maintains order to be used for sorted-map)

Adding test to ensure order preserved for a large map
jeff303 added a commit to jeff303/specter that referenced this issue Sep 18, 2020
@jeff303
submap sub map should maintain properties of parent map redplanetla…
85361b1 
…bs#235

Adding new SubMap protocol to provide a different implementation of select-keys for TreeMap

Adding tests to ensure order preserved for a large map, as well as one
with a custom comparator
jeff303 added a commit to jeff303/specter that referenced this issue Sep 18, 2020
@jeff303
submap sub map should maintain properties of parent map redplanetla…
a8151c6 
…bs#235

Adding new SubMap protocol to provide a different implementation of select-keys for TreeMap

Adding tests to ensure order preserved for a large map, as well as one
with a custom comparator
jeff303 added a commit to jeff303/specter that referenced this issue Sep 18, 2020
@jeff303
submap sub map should maintain properties of parent map redplanetla…
07c3bf8 
…bs#235

Adding new SubMap protocol to provide a different implementation of
select-keys for TreeMap

Adding tests to ensure order preserved for a large map, as well as one
with a custom comparator
@jeff303 jeff303 mentioned this issue Sep 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathanmarz