Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing topic config modal UI looks different after component migration #1086

Open
weeco opened this issue Feb 6, 2024 · 1 comment
Open
Assignees
Labels

Comments

@weeco
Copy link
Contributor

weeco commented Feb 6, 2024

When we migrated components from AntD to redpanda-data/ui we prioritized getting components migrated over ui/ux. Editing topic configs was one of the modals that suffered.

Before component migration (screenshot from a video, hence low quality):

ss-TArsI8Au

Today:

ss-3TUbU754

ss-JWdx4KOu

@ivpanda
Copy link

ivpanda commented Feb 16, 2024

Design

After getting some feedback, this is the proposed design:

image
image

There is:

  • A definition of retention.bytes (or retention.ms)
  • A selection of default, infinite, or custom
  • If default, then we state what the default is and where it's inherited from
  • If infinite, we state what 'infinite' means: that a compaction will never be triggered
  • If custom, we add a dropdown with the options: bytes, KiB, MiB, GiB, and TiB. 'infinite' is no longer here. The user can still use -1 to indicate infinite, but we won't advertise that.

Other options

Radio buttons:

image

The reason I didn't choose this one was because it's a lot of information to take in at the outset.

Default and custom:

image

This was initially desired, but the lack of clarity around the 'infinite' option made this less desirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants