Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TweetStreamConsumer to handle connection failures #435

Open
snicoll opened this issue Feb 23, 2023 · 1 comment
Open

Improve TweetStreamConsumer to handle connection failures #435

snicoll opened this issue Feb 23, 2023 · 1 comment

Comments

@snicoll
Copy link
Contributor

snicoll commented Feb 23, 2023

Looking at the current state of affairs, TweetStreamConsumer is going to call onStreamEnded when an IOException occurs. Such (network) exception can happen for a variety of reasons and some of them are recoverable by attempting to closed and open the socket again. For instance operational-disconnect should be recoverable.

While the listener offers an exit strategy, the onus is on the user and that feels something the library could offer for everyone.

See also:

@snicoll
Copy link
Contributor Author

snicoll commented Mar 4, 2023

FTR, twittered does not work at all with the Apache Async HTTP client (and perhaps any async client) due to how scribejava handles them.

You may be interested by scribejava/scribejava#1054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant