Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pushing metrics to prometheus #444

Open
DestroyerAlpha opened this issue Jan 11, 2024 · 9 comments
Open

Support for pushing metrics to prometheus #444

DestroyerAlpha opened this issue Jan 11, 2024 · 9 comments

Comments

@DestroyerAlpha
Copy link
Contributor

First of all thanks for constantly developing this library based on inputs from the community. I am glad to see that we have instrumented connection level metrics via rueidisotel. I was wondering if it would be possible to have a way to push these metrics to prometheus as well? Something like https://github.com/redis/go-redis/tree/master/extra/redisprometheus.

Would be happy to work on this, if needed, as well.

@rueian
Copy link
Collaborator

rueian commented Jan 11, 2024

Hi @DestroyerAlpha,

Does an otel prometheus exporter fit your needs?
https://github.com/open-telemetry/opentelemetry-go/blob/main/example/prometheus/main.go

@DestroyerAlpha
Copy link
Contributor Author

We are on go1.18 so probably would have to upgrade the go version for that as well, since it requires go1.20. Do we see a future plan to integrate it inhouse?

@rueian
Copy link
Collaborator

rueian commented Jan 12, 2024

Do we see a future plan to integrate it inhouse?

Sorry, I didn’t get you. What did you mean by that? Or what kind of functionalities you need to integrate with your in-house infrastructure?

@DestroyerAlpha
Copy link
Contributor Author

I meant do we plan to export prom metric internally from rueidis instead of using an exporter?

@rueian
Copy link
Collaborator

rueian commented Jan 13, 2024

@DestroyerAlpha,

Oh, I see. Yes, we can have a rueidisprom subpackage if we keep the core rueidis depending on fewer packages.

So, there are two things we can do:

  1. Introduce the rueidisprom subpackage with its own go.mod separated from the root one.
  2. Let rueidisotel have its own go.mod (Move OpenTelemetry dependencies to rueidisotel subpackage #447).

Would you like to help the first one?

@DestroyerAlpha
Copy link
Contributor Author

Sure I can help with the first one

@DestroyerAlpha
Copy link
Contributor Author

Added a PR for the same @rueian

@rueian
Copy link
Collaborator

rueian commented Feb 1, 2024

Hi @DestroyerAlpha,

I would like to release the next v1.0.28 recently. Is there any chance of bringing the real implementation rueidisprom subpackage to life? Or I may need to revert it when releasing the next version.

@DestroyerAlpha
Copy link
Contributor Author

@rueian Hey would raise a PR for this ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants