Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events Hero "Sidebar Button" color is wrong with one event & when using .light #364

Open
ghost opened this issue Oct 15, 2019 · 0 comments
Open

Events Hero "Sidebar Button" color is wrong with one event & when using .light #364

ghost opened this issue Oct 15, 2019 · 0 comments
Assignees
@alistairmc
Projects
Q2FY2020 Design Surge

Comments

@ghost
Copy link

ghost commented Oct 15, 2019 •
edited by ghost

  1. The Sidebar Button link icon span color is wrong with .light regardless of event count.
  2. The Sidebar Button color is wrong with .light when there is only one event.

*Note: I think part of this is due to the fact that we are using a tags instead of buttons on the Drupal side.

Sidebar Button with one event:

Screen Shot 2019-10-15 at 9 50 29 AM

Sidebar Button with more than one event:

Screen Shot 2019-10-15 at 9 44 31 AM
@ghost ghost created this issue from a note in Q2FY2020 Design Surge (Priority-Ordered) Oct 15, 2019
@ghost ghost assigned alistairmc Oct 15, 2019
@ghost ghost changed the title Events Hero "Sidebar Button" color is wrong with one event. Events Hero "Sidebar Button" color is wrong with one event & when using .light Oct 15, 2019
@ghost ghost mentioned this issue Oct 15, 2019
Merged
@alistairmc alistairmc moved this from Priority-Ordered to In progress in Q2FY2020 Design Surge Oct 15, 2019
@alistairmc alistairmc moved this from In progress to Review in Q2FY2020 Design Surge Oct 15, 2019
@alistairmc alistairmc moved this from Review to Reviewed in Q2FY2020 Design Surge Oct 15, 2019
@alistairmc alistairmc moved this from Reviewed to Done in Q2FY2020 Design Surge Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alistairmc alistairmc

Labels
None yet
Projects
Q2FY2020 Design Surge
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alistairmc