Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axis/Direction Normalization #305

Open
gottfriedleibniz opened this issue May 26, 2023 · 2 comments
Open

Axis/Direction Normalization #305

gottfriedleibniz opened this issue May 26, 2023 · 2 comments

Comments

@gottfriedleibniz
Copy link

gottfriedleibniz commented May 26, 2023

In certain places through this library, I've noticed the branching from the internal/implicit normalization can cause a pretty big hit in otherwise pipeline-friendly code. For example:

I was wondering if (A) anybody else has experienced/measured this; and (B) would it be possible to introduce functions (or something else, e.g., a build option) that assume these 'axis' or 'direction' parameters are already normalized.

Edit: Clarity.

@recp
Copy link
Owner

recp commented May 27, 2023

would it be possible to introduce functions (or something else, e.g., a build option) that assume these 'axis' or 'direction' parameters are already normalized.

Actually that would be nice, if passed axis and direction are already unit / normalized that would be redundant and extra overhead to normalize them again :(

Any suggestions? Maybe we could provide alternative functions plus build configuration to change existing behavior if it is desired

@gottfriedleibniz
Copy link
Author

Any suggestions?

Breaking backwards compatibility :). Otherwise, what you suggest seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants