Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop in triangulateHull when detailSampleDist == 0 #650

Open
MichaelSuen-thePointer opened this issue Jul 26, 2023 · 0 comments
Open

Comments

@MichaelSuen-thePointer
Copy link

Looks like setting detailSampleDist to 0 but also calling rcBuildPolyMeshDetail is accepted.

But when detailSampleDist is 0, nhull in buildPolyDetail is 0, thus making left = 1 and right = -1 in triangulateHull, which then caused an infinite loop here

I'm not very familiar with the code logic here, should it be changed to next(left, nhull) < right ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants