Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcConfig Improvements #557

Open
grahamboree opened this issue Oct 12, 2022 · 0 comments
Open

rcConfig Improvements #557

grahamboree opened this issue Oct 12, 2022 · 0 comments

Comments

@grahamboree
Copy link
Member

The values width and height are generally derived from other config values, but they're part of rcConfig which implies that they're meant to be user inputs to the rasterization process and should be set before creating the heightfield.

When building using the solo mesh process, the values width and height are derived from cs and bmin/bmax using rcCalcGridSize.

When building tile meshes, these values are simply defined as m_cfg.tileSize + m_cfg.borderSize*2.

These should just be computed from the other config values at the point they're needed.

Simple naming improvements

height: this is the z-axis size of the rasterized area. In every other case "height" refers to the y axis (e.g. ch) so this should be changed to something like depth
cs : rename to cellSize
ch: rename to cellHeight

🚨 These changes will create breaking API changes. We should be very deliberate about our release process for incorporating breaking API changes like this.

@grahamboree grahamboree self-assigned this Oct 12, 2022
@grahamboree grahamboree added this to the 2.0.0 milestone Jul 4, 2023
@grahamboree grahamboree removed their assignment Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant