New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duDebugDrawHeightfieldLayer check against h instead of lh #506

Open

nicoell opened this issue Dec 14, 2021 · 0 comments

Labels

area: Recast needs confirmation type: bug

nicoell commented Dec 14, 2021

recastnavigation/DebugUtils/Source/RecastDebugDraw.cpp

Lines 392 to 398 in c5cbd53

    
           for (int y = 0; y < h; ++y) 
        
           { 
        
           	for (int x = 0; x < w; ++x) 
        
           	{ 
        
           		const int lidx = x+y*w; 
        
           		const int lh = (int)layer.heights[lidx]; 
        
           		if (h == 0xff) continue;

I believe the check in line 398 is supposed to be on lh not h. Or am I missing something?

grahamboree added type: bug labels

grahamboree added area: Recast needs confirmation labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment