Replies: 1 comment 1 reply
-
Hi! I'm not terribly familiar with cmake's build configuration system, but I assume it's essentially setting C preprocessor variables like other build systems do. I'd be open to moving these integers to |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Those are currently global constants, which require modifying recast's source itself (see this issue from a game that uses recast).
Would it be ok to make it possible to make this a cmake option instead? This way, it would be possible for users to at least change the value at compilation time without having to modify recast's code directly.
If yes, I'll write a PR for this.
Maybe it would be possible to make the value dynamic at runtime too, but I'm not sure how much this would require patching or if it would be a bad idea for performance or other techical reasons.
Beta Was this translation helpful? Give feedback.
All reactions