Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme says npm i or add deps to .edn but (in my case at least) needed both #591

Open
DeepReef11 opened this issue Jun 7, 2023 · 1 comment

Comments

@DeepReef11
Copy link

DeepReef11 commented Jun 7, 2023

Hi,

I've had troubles using Reagent because of this little or in the readme. I don't know if there are reasons to not install react and react-dom with npm but since it was saying or, I've skipped it and it caused errors. Maybe a little bit of clarification or replace 'or' by 'and' would prevent futur problems.

Readme.md:

And provide React using either npm (when using e.g. Shadow-cljs)

npm i react react-dom

or by adding Cljsjs React packages to your project:

[cljsjs/react "17.0.2-0"]
[cljsjs/react-dom "17.0.2-0"]

@Deraen
Copy link
Member

Deraen commented Jun 9, 2023

It is "or" on purpose.

Shadow-cljs should work without cljsjs libs as it doesn't need even the extern files from those. Reagent test suite should be running Shadow-cljs build without cljsjs libs.

What kind of errors have you seen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants