Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Readium SDK as Module #109

Open
dilawer opened this issue Dec 26, 2016 · 15 comments
Open

Import Readium SDK as Module #109

dilawer opened this issue Dec 26, 2016 · 15 comments

Comments

@dilawer
Copy link

dilawer commented Dec 26, 2016

I have been using readium sdk in iOS app, and also did some customization on android SDK launcher and need to utilize it in one of our android app.

I have already integrated the app as module, epub as module but when I try to compile my app, it shows errors with git. Please check this https://cloudup.com/c4W-TpsY5Ny

I am getting similar error if I pull readium-sdkLauncher code from git and the copy it to another place and try to run there.

Please let me know solution, I already tried multiple solutions on web. I need this to be fixed soon.
I already send you email at rkwright@readium.org

@danielweck
Copy link
Member

If the problem persists, please disable / remove the git / versioning / epubReadingSystem task from the gradle script. It is not not critical to the build process, especially if you are not using the exact git repository / submodule source tree as the default ReadiumSDK Android "app launcher".

@rkwright
Copy link
Member

@dilawer I responded to your email to rkwright@readium.org. Feel free to send me email there (or rkwright@geofx.com) but you will get your best and fastest response here in the issue tracker or on Slack (about which I also sent you info). Thanks!

@dilawer
Copy link
Author

dilawer commented Jan 3, 2017

Hi Daniel,

I am still having problems with this.

I removed/commented epubReadingSystem task, please check here but its creating new issues https://cloudup.com/cnMVddHbmPd

can you please mention what line of script I have to remove or comment ?

Thanks

@danielweck
Copy link
Member

Comment line 43:
apply from: 'build_epubReadingSystem.gradle'
https://github.com/readium/SDKLauncher-Android/blob/develop/SDKLauncher-Android/app/build.gradle#L43

Comment line 51:
"buildEpubReadingSystem"
(remember to also remove the suffix , comma character at the end of previous line 50)
https://github.com/readium/SDKLauncher-Android/blob/develop/SDKLauncher-Android/app/build.gradle#L51

@dilawer
Copy link
Author

dilawer commented Jan 3, 2017

Thanks, for your quick response.

Now its providing me more errors https://cloudup.com/calpEM3ne57

Please check..Thanks

@danielweck
Copy link
Member

danielweck commented Jan 3, 2017

Make sure to download and unzip the Android NDK (r13b) in a known location.
https://developer.android.com/ndk/downloads/index.html

Ensure that the file local.properties file in your readium/SDKLauncher-Android/SDKLauncher-Android/ directory (yes, the double folder name is correct) contains:

sdk.dir=PATH_TO/android-sdk
ndk.dir=PATH_TO/android-ndk-r13b

@dilawer
Copy link
Author

dilawer commented Jan 3, 2017

This is what I have https://cloudup.com/coXOyYtKRv3

I have the NDK bundles. I want to mention here again, this SDK works fine for me when I clone it from this repo. I want to make it as a module and import in my other project which is creating problem for me.

This problem also occurs when I clone repo from this git source, and copy the parent folder, move it some where else (other folder or machine) it give me the same errors

@dilawer
Copy link
Author

dilawer commented Jan 4, 2017

Hey guys. Any update on this ?

@danielweck
Copy link
Member

Do you use Maven to modularize the source tree / library dependencies?

@dilawer
Copy link
Author

dilawer commented Jan 6, 2017

@danielweck I am using android studio. It has gradle. I dont think I use Maven.

Can you please provide steps on how I can make the sdk launcher downloaded from GIT and make it a module of any other android project ?

I already told you that I face same situation when I dont do anything to downloaded project and just copy to another location and run from there.

I need solution its blocking me to finish my application.

@dilawer
Copy link
Author

dilawer commented Jan 9, 2017

@rkwright @danielweck I am waiting, because I want to finish my application in which I am using this sdk launcher.

Please provide solution. Let me know if you need more details regarding what I mention.

Thanks

@dilawer
Copy link
Author

dilawer commented Jan 10, 2017

@danielweck @rkwright Guys, can I get an update on this?

Thanks

@danielweck
Copy link
Member

@dilawer hello, please remember that this is an open-source, community-driven software project. Based on the information we exchanged so far, I am not able to pin-point what your problem is. Can you use the source tree as provided by the default "git clone", rather than your folder copy?

@dilawer
Copy link
Author

dilawer commented Jan 10, 2017

@danielweck I understand that its a community-driven software project.

I used the source tree and used the project by git clone. I did my modification in that (whatever required) everything works fine in the sdklauncher sample app in the project after I do git clone.

Now, I want to use that in my own app and at that point I am started having issues with it that I already mentioned "I have already integrated the app as module, epub as module but when I try to compile my app, it shows errors with git. Please check this https://cloudup.com/c4W-TpsY5Ny

I am getting similar error if I pull readium-sdkLauncher code from git and the copy it to another place and try to run there."

lets forget about my issues, what if someone want to use SDK in their own project, same issues I am having with.

apology if I ping you alot.

@danielweck
Copy link
Member

No apologies needed. I just wanted to clarify (for anybody reading this discussion thread) that contributors do what they can to help given their limited time.
In some cases, bugs are hard to reproduce, and/or there isn't enough information to offer quick solutions.
Your particular integration problem has not been reported before, so it is hard to pin-point why this is not working out in your case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants