Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portal cause context broken in React 16 #1919

Open
januszhou opened this issue Jun 13, 2019 · 0 comments
Open

Portal cause context broken in React 16 #1919

januszhou opened this issue Jun 13, 2019 · 0 comments

Comments

@januszhou
Copy link

januszhou commented Jun 13, 2019 •
edited

The current Portal created by ReactDOM.unstable_renderSubtreeIntoContainer isn't support new context API, it should start using ReactDOM.createPortal instead. I'm willing to open a PR if needed

reference: facebook/react#12493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@januszhou