Bugs + (partial) Fixes: Non-responsiveness of "tabBarLabelStyle" and "tabBarLabel" in MaterialTopTabBar #11983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaterialTopTabBar is ignoring the prop "tabBarLableStyle", so the label style couldn't be changed. The bug was that the MaterialLabelType variable "lableStyle" is incompatible with the "label" input variable of customlabel in TabBarItemInternal (react-native-tab-view).
The prop "tabBarLabel" is ignored by MaterialTopTabBar. It only displays the route name. This fix allows strings for "tabBarLabel" but no components (as suggested by docs).
labelStyle is not being passed through to TabBarItem -> TabBarItemInternal
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
we need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bug fix: The props tabBarLabelStyle and tabBarLabel are ignored by MaterialTopTabBar. This pull requests solves the problem full for tabBarLabelStyle. For tabBarLabel this PR only fixes the problem for tabBarLabel(s) of type string.
Test plan
Create a MaterialTopTabBar navigator with customized tab bar label style(s) (prop: "tabBarLabelStyle") which is currently ignored. After merging the commit, this should not be the case anymore. The same applies to the "tabBarLabel".