Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useHeaderHeight changes several times when orientation changes #11915

Closed
3 of 11 tasks
Gregoirevda opened this issue Mar 27, 2024 · 4 comments
Closed
3 of 11 tasks

useHeaderHeight changes several times when orientation changes #11915

Gregoirevda opened this issue Mar 27, 2024 · 4 comments

Comments

@Gregoirevda
Copy link

Current behavior

In tablet, changing orientation causes the app to flicker and taking time to resize itself because many part of the app rely on a fairly static useHeaderHeight() value. (Including ScrollView contentContainerStyle and useEffects).
When changing orientation, statusBarHeight goes from X to 0 and back to X. Causing many "re-layouts".

This only happens when going from landscape to portrait.

The reason is useSafeAreaInsets().top which goes from X to 0 to X.

Expected behavior

statusBarHeight should not jump to 0 when changing orientation

Reproduction

l

Platform

  • Android
  • iOS
  • Web
  • Windows
  • MacOS

Packages

  • @react-navigation/bottom-tabs
  • @react-navigation/drawer
  • @react-navigation/material-top-tabs
  • @react-navigation/stack
  • @react-navigation/native-stack
  • react-native-tab-view

Environment

  • [] I've removed the packages that I don't use
package version
@react-navigation/native
@react-navigation/native-stack
react-native-safe-area-context
react-native-screens
react-native
node
npm or yarn
Copy link

Hey @Gregoirevda! Thanks for opening the issue. It seems that the issue doesn't contain a link to a repro.

The best way to get attention to your issue is to provide an easy way for a developer to reproduce the issue.

You can provide a repro using any of the following:

A snack link is preferred since it's the easiest way to both create and share a repro. If it's not possible to create a repro using a snack, link to a GitHub repo under your username is a good alternative. Don't link to a branch or specific file etc. as it won't be detected.

Try to keep the repro as small as possible by narrowing down the minimal amount of code needed to reproduce the issue. Don't link to your entire project or a project containing code unrelated to the issue. See "How to create a Minimal, Reproducible Example" for more information.

You can edit your original issue to include a link to the repro, or leave it as a comment. The issue will be closed automatically after a while if you don't provide a repro.

Copy link

Couldn't find version numbers for the following packages in the issue:

  • @react-navigation/native

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

@Gregoirevda
Copy link
Author

Opened an issue in react-native-safe-area context as the issue is coming from there th3rdwave/react-native-safe-area-context#485

Copy link

Hello 👋, this issue has been open for more than a month without a repro or any activity. If the issue is still present in the latest version, please provide a repro or leave a comment within 7 days to keep it open, otherwise it will be closed automatically. If you found a solution or workaround for the issue, please comment here for others to find. If this issue is critical for you, please consider sending a pull request to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant