-
-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New architecture support #1090
Comments
Hello, thanks for asking! Currently, I'm not planning to put any effort into it but I have added one-time sponsorship options to my GH sponsors account ranging from $15 up. Anyone who uses the package and wants me to migrate it to the new architecture can sponsor the effort and once a reasonable amount gets collected, I'll do the migration 🙂 . Thanks so much! ❤️ |
What is the "new architecture"? Are y'all referring to the new Google Identity Services? (is this project going to break after March 31?) EDIT: I see some discussion over here that seems to be answering my second question #1134 But I still wonder, what is the "new architecture" you two are discussing here? @vonovak @TheRogue76 |
@jklnr the new architecture refers to major changes in how react native works under the hood; the module needs to be made compatible with the new architecture https://reactnative.dev/docs/next/the-new-architecture/landing-page |
This comment was marked as spam.
This comment was marked as spam.
It would be nice if all the interested, and willing to pay for this feature, add a comment here, so we can track & make a group payment. I am willing to add some money there 🖐 it would also be nice to know how much we should collect |
Thanks @BrodaNoel for expressing your support, it's much appreciated! 🙂 To reiterate, here are the sponsorship options for those interested. There is a $59 tier that I created for "New architecture rewrites".
I don't have a goal to be honest, and if I did I'd probably end up being disappointed I think 😅 - this issue and the call for sponsors has been open for 6 months and so far I think I collected $15 from this nice guy 😄. That being said, I'm not contributing to open source for profit. But at the same time, I don't feel like doing it with 0 compensation which is why I have GH sponsors. I have a few sponsors who contribute monthly, and once in a while when that adds up to a reasonable amount, I hack something together. For example, right now I'm migrating the date time picker to new arch and this migration could be next. I'm going to say that I'd really like to see donations from companies rather than individuals. I'm sure that there are companies using this module in for-profit apps and I'd love to see them understand that sponsoring their dependencies is for their own good. Thank you 🙂 |
Hi @vonovak, if you could secure a company sponsorship, would supporting the latest architecture and taking this library out of "maintenance mode" be feasible? |
Hi, yes, absolutely! 🙂 |
I'm closing this in favor of #942 thank you! |
I'm reopening, I started the migration here #1181 If you appreciate the effort, please do use the sponsorships as discussed above. Thank you |
Hello, just a quick update: I implemented the new architecture support, and it's available if you follow the instructions here https://github.com/react-native-google-signin/google-signin#project-setup-and-initialization Note that it requires sponsoring the project - there were some comments that suggested that there is a potential interest in sponsoring. Now you can do it, and get the value out of it right away 👍 . Thank you and I hope you understand I made it this way - I also need to pay my bills 🙂 |
Hey. This is not an issue so much as a feature request, and it is mostly just keeping track to see what efforts are put into it and helping out if we can. I did not find anything related to it in the repo or the history so i'm just coming here to ask. Are there any plans for the new arch support?
https://reactnative.dev/docs/next/the-new-architecture/landing-page
The text was updated successfully, but these errors were encountered: