Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New architecture support #1090

Closed
TheRogue76 opened this issue Aug 11, 2022 · 10 comments
Closed

New architecture support #1090

TheRogue76 opened this issue Aug 11, 2022 · 10 comments

Comments

@TheRogue76
Copy link

TheRogue76 commented Aug 11, 2022

Hey. This is not an issue so much as a feature request, and it is mostly just keeping track to see what efforts are put into it and helping out if we can. I did not find anything related to it in the repo or the history so i'm just coming here to ask. Are there any plans for the new arch support?

https://reactnative.dev/docs/next/the-new-architecture/landing-page

@vonovak vonovak changed the title New architecture New architecture support Aug 12, 2022
@vonovak
Copy link
Member

vonovak commented Aug 12, 2022

Hello, thanks for asking!

Currently, I'm not planning to put any effort into it but I have added one-time sponsorship options to my GH sponsors account ranging from $15 up. Anyone who uses the package and wants me to migrate it to the new architecture can sponsor the effort and once a reasonable amount gets collected, I'll do the migration 🙂 .

Thanks so much! ❤️

@vonovak vonovak pinned this issue Aug 27, 2022
@jklnr
Copy link

jklnr commented Jan 30, 2023

What is the "new architecture"? Are y'all referring to the new Google Identity Services?

(is this project going to break after March 31?)

EDIT:

I see some discussion over here that seems to be answering my second question #1134

But I still wonder, what is the "new architecture" you two are discussing here? @vonovak @TheRogue76

@vonovak
Copy link
Member

vonovak commented Jan 31, 2023

@jklnr the new architecture refers to major changes in how react native works under the hood; the module needs to be made compatible with the new architecture https://reactnative.dev/docs/next/the-new-architecture/landing-page

@BraveEvidence

This comment was marked as spam.

@BrodaNoel
Copy link

BrodaNoel commented Mar 8, 2023

It would be nice if all the interested, and willing to pay for this feature, add a comment here, so we can track & make a group payment.

I am willing to add some money there 🖐

it would also be nice to know how much we should collect

@vonovak
Copy link
Member

vonovak commented Mar 8, 2023

Thanks @BrodaNoel for expressing your support, it's much appreciated! 🙂

To reiterate, here are the sponsorship options for those interested. There is a $59 tier that I created for "New architecture rewrites".

it would also be nice to know how much we should collect

I don't have a goal to be honest, and if I did I'd probably end up being disappointed I think 😅 - this issue and the call for sponsors has been open for 6 months and so far I think I collected $15 from this nice guy 😄.

That being said, I'm not contributing to open source for profit. But at the same time, I don't feel like doing it with 0 compensation which is why I have GH sponsors. I have a few sponsors who contribute monthly, and once in a while when that adds up to a reasonable amount, I hack something together. For example, right now I'm migrating the date time picker to new arch and this migration could be next.

I'm going to say that I'd really like to see donations from companies rather than individuals. I'm sure that there are companies using this module in for-profit apps and I'd love to see them understand that sponsoring their dependencies is for their own good.

Thank you 🙂

@ryanjwessel
Copy link

Hi @vonovak, if you could secure a company sponsorship, would supporting the latest architecture and taking this library out of "maintenance mode" be feasible?

@vonovak
Copy link
Member

vonovak commented Mar 15, 2023

Hi @vonovak, if you could secure a company sponsorship, would supporting the latest architecture and taking this library out of "maintenance mode" be feasible?

Hi, yes, absolutely! 🙂

@vonovak
Copy link
Member

vonovak commented Jun 10, 2023

I'm closing this in favor of #942

thank you!

@vonovak vonovak closed this as completed Jun 10, 2023
@vonovak
Copy link
Member

vonovak commented Jul 12, 2023

I'm reopening, I started the migration here #1181

If you appreciate the effort, please do use the sponsorships as discussed above. Thank you

@vonovak vonovak reopened this Jul 12, 2023
@vonovak
Copy link
Member

vonovak commented Jul 18, 2023

Hello, just a quick update: I implemented the new architecture support, and it's available if you follow the instructions here https://github.com/react-native-google-signin/google-signin#project-setup-and-initialization

Note that it requires sponsoring the project - there were some comments that suggested that there is a potential interest in sponsoring. Now you can do it, and get the value out of it right away 👍 .

Thank you and I hope you understand I made it this way - I also need to pay my bills 🙂

@vonovak vonovak closed this as completed Jul 25, 2023
@vonovak vonovak unpinned this issue Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants
@vonovak @BrodaNoel @ryanjwessel @BraveEvidence @TheRogue76 @jklnr and others