Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File paths missing slash when app name omitted #381

Open
frankcalise opened this issue Apr 11, 2024 · 0 comments
Open

File paths missing slash when app name omitted #381

frankcalise opened this issue Apr 11, 2024 · 0 comments

Comments

@frankcalise
Copy link
Contributor

Bug

File paths show the app name as the root directory when there is no app name provided, however the first slash is missing in the path resulting in RnDiffApppackage.json for example, rather than RnDiffApp/package.json.

It is properly slashed for directories below this.

In addition to that, there is an inconsistency where if you fill out the app name input, it's just removed altogether from the file paths.

If we're expecting the app name to not show in those title bars, then we'd just need to drop the placeholder name from the title bars (since we don't see it with a custom app name).

upgrade-helper-file-path.mp4

Steps to reproduce

Describe what you expected to happen:

  1. Press Show me how to upgrade!, observe that RnDiffApp/package.json is displayed in the first title bar

  2. Fill out the app name input, press Show me how to upgrade!, observe that the custom app name is displayed in the first title bar such as MyApp/package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant