Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript error after upgrading to >= v3.1.1 #631

Open
ThomasSertorio opened this issue Sep 22, 2023 · 6 comments
Open

TypeScript error after upgrading to >= v3.1.1 #631

ThomasSertorio opened this issue Sep 22, 2023 · 6 comments

Comments

@ThomasSertorio
Copy link

Describe the bug
I am building a form with a "dynamic" Yup schema. According to some user actions, the set of inputs to fill in is selected among different choices. I have this "working" with @hookform/resolvers 3.1.0 but when upgrading to 3.1.1 or above, I get a TypeScript error on the resolver type.

To Reproduce
Step to reproduce the behavior:

Codesandbox link (Required)
Sandbox: https://codesandbox.io/s/serene-glitter-lct3zp?file=/src/App.tsx

Desktop (please complete the following information):

  • OS: [Ventura 13.5.2]
  • Browser [Chrome]
  • Version [117]
@nikitalepikhin
Copy link

I wanted to create an issue regarding this error but turns out there is already this one. However, I have already created a playground to showcase this error. Perhaps my playground would be easier to understand.

Codesandbox link: https://codesandbox.io/s/relaxed-chatterjee-p5scpp?file=/src/App.tsx.

Steps to reproduce the error:

  • open the playground, the linked version uses @hookform/resolvers library v3.0.0 - this version works just fine
  • update the version of the library to the latest one - at the time of writing it is v3.3.1
  • an error will appear on line 47 - where the resolver is defined

SCR-20231003-kkaj

@Callenowy
Copy link

Yeah, the mentioned issue occurs also in my project

eslint-any-error

@crow7m
Copy link

crow7m commented Oct 12, 2023

Hi, thank you for the great library, any ideas on how to fix this ? meanwhile rolled back to 3.0.0

@mpash
Copy link

mpash commented Oct 18, 2023

Ran into this myself recently.

Yup v1.* has a compiler flag requirement.

You must have the strictNullChecks compiler option enabled for type inference to work.
https://github.com/jquense/yup#typescript-configuration

I also defined my schema and typed it using the ObjectSchema generic which accepts the expected object structure inside of it. https://github.com/jquense/yup#ensuring-a-schema-matches-an-existing-type


Versions:

@hookform/resolvers 3.3.2
react-hook-form 7.47.0
yup 1.3.2

@Callenowy
Copy link

It looks like this issue is gone after upgrading @hookform/resolvers to the latest version.

@jilv220
Copy link

jilv220 commented Oct 29, 2023

The issue is gone for me after updated to the latest version as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants