Skip to content
This repository has been archived by the owner on Dec 6, 2018. It is now read-only.

Could bs-platform be changed to a devDependency? #5

Open
desmond-dsouza opened this issue Jan 7, 2018 · 3 comments
Open

Could bs-platform be changed to a devDependency? #5

desmond-dsouza opened this issue Jan 7, 2018 · 3 comments

Comments

@desmond-dsouza
Copy link

[Thank you sooo much for this project!]

Allows for a global install + npm link.

bs-react-native currently uses:

	"devDependencies": {
		"bs-platform": "^2.1.0",
		"reason-react": "^0.3.0"
	},
	"peerDependencies": {
		"reason-react": "^0.3.0",
		"react-native": "^0.46.0"
	}
@brentvatne
Copy link
Member

makes sense, yeah we could do that

@desmond-dsouza
Copy link
Author

ok, submitted a PR #6

@desmond-dsouza
Copy link
Author

Hmm. I don't think the packager can correctly handle symbolic links. Not sure.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants