Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkContainer turns all children's tags into a's. #261

Open
dennisoelkers opened this issue Oct 15, 2020 · 1 comment
Open

LinkContainer turns all children's tags into a's. #261

dennisoelkers opened this issue Oct 15, 2020 · 1 comment

Comments

@dennisoelkers
Copy link

We are currently upgrading from react-router v3 to v5, therefore also upgrading react-router-bootstrap from v0.23.3 to v0.25.0. We have noticed that LinkContainer (which is just wrapping Route) is turning all children into a-tags, even though e.g. a Button component is passed.

Is this on purpose? Is there any way around this?

Right now it is breaking our tests (we are assuming e.g. that a button component is used in some places).

@antoHuman
Copy link

This is something that I expect, as it works well with react bootstrap Button component. The final element is an anchor a with the style of a button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants