Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore usage dom-helper.ownerDocument in useRootClose like in RootCloseWrapper #746

Open
Viktor-the-great opened this issue Dec 6, 2019 · 4 comments
Open

restore usage dom-helper.ownerDocument in useRootClose like in RootCloseWrapper #746

Viktor-the-great opened this issue Dec 6, 2019 · 4 comments

Comments

@Viktor-the-great
Copy link
Contributor

Describe the bug

Dropdown inside iframe is not trigger "root close" for iframe document

To Reproduce

Steps to reproduce the behavior:

  1. Render Dropdown inside iframe
  2. Open Menu
  3. Click outside Menu (inside iframe)
  4. Menu is not closed

Expected behavior

Dropdown should closed
@taion
Copy link
Member

taion commented Dec 6, 2019

Is this a regression?

@Viktor-the-great
Copy link
Contributor Author

If regression is to restore functionality from v1.2.0, then yes

@taion
Copy link
Member

taion commented Dec 9, 2019

Regression from v1.2.0, I mean – in which case we'd be happy to take a PR here.

@Viktor-the-great
Copy link
Contributor Author

PR #751

Viktor-the-great pushed a commit to Viktor-the-great/react-overlays that referenced this issue Dec 10, 2019
ref is defined (react-bootstrap#746)
24f5d39
taion pushed a commit that referenced this issue Dec 10, 2019
@Viktor-the-great @taion
use ownerDocument to get ref to parent document (#746) (#751)
cddc418 
* use ownerDocument to get ref to parent document (746)

* ref is defined (#746)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Viktor-the-great @taion