Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong ordering #944

Closed
leucoryx opened this issue Mar 19, 2024 · 2 comments · Fixed by #947
Closed

Wrong ordering #944

leucoryx opened this issue Mar 19, 2024 · 2 comments · Fixed by #947
Assignees
@jochenklar
Labels
effort:minor type:bug
Milestone
RDMO 2.2.0

Comments

@leucoryx
Copy link
Collaborator

Fragenkatalog_Buttons

You can create a question directly from a page. You have three options:
"Add existing element", "Create new question set" or "Create new question".

Incorrectly, if you click on "Create new question set", a new question is created and if you click on "Create new question", a new question set is created. The two links are therefore reversed!

(Version 2.1.3)
@MyPyDavid
Copy link
Member

yes, thanks! the texts of the buttons are swapped:

rdmo/rdmo/management/assets/js/components/edit/EditPage.js

Lines 73 to 74 in c945d7d

const createQuestionText = gettext('Create new question set')
const createQuestionSetText = gettext('Create new question')

@MyPyDavid MyPyDavid added this to the RDMO 2.1.4 milestone Mar 19, 2024
@jochenklar jochenklar modified the milestones: RDMO 2.1.4, RDMO 2.2.0 Mar 26, 2024
@jochenklar jochenklar self-assigned this Mar 26, 2024
jochenklar added a commit that referenced this issue Mar 26, 2024
@jochenklar
Fix edit component for page and question set (#944)
d89ba8a
@MyPyDavid MyPyDavid linked a pull request Apr 4, 2024 that will close this issue
Fix edit component for page and question set (#944) #947
Merged
jochenklar added a commit that referenced this issue May 14, 2024
@jochenklar
Merge pull request #947 from rdmorganiser/fix_page_management
f654664 
Fix edit component for page and question set (#944)
@jochenklar
Copy link
Member

This will be part of the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jochenklar jochenklar

Labels
effort:minor type:bug
Projects
None yet
Milestone
RDMO 2.2.0
Development

Successfully merging a pull request may close this issue.

Fix edit component for page and question set (#944) rdmorganiser/rdmo
3 participants
@jochenklar @MyPyDavid @leucoryx