Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multipule CTRL + C breaking exit sequence #484

Open
Petrarka0 opened this issue Apr 6, 2024 · 3 comments · May be fixed by #490
Open

multipule CTRL + C breaking exit sequence #484

Petrarka0 opened this issue Apr 6, 2024 · 3 comments · May be fixed by #490
Assignees
Labels
🐜 bug Something isn't working 🧱 enhancement New feature or request

Comments

@Petrarka0
Copy link

Describe the bug

After mulipule times user click CTRL+ С program closes websockets, leaving chats, but doesn't self.__print_report() and sys.exit(0)
Console doesn't respond anymore to CTRL+C and no more logs printed. Program stucc in limbo

Steps to reproduce

  1. Click CTRL+C muliple times in short time
  2. Program closes websockets, leaving chats, but doesn't self.__print_report() and sys.exit(0)
  3. Console doesn't respond to CTRL+C anymore and no more logs etc

Expected behavior

closing program no matter how much times user click ctrl+c

Operating system

win 11 x64

Python version

3.12.2

Miner version

1.9.4

Other relevant software versions

No response

Logs

mulipule CTRL+C bug logs
multipule CTRL+C bug console output

Additional context

No response

@Petrarka0
Copy link
Author

Petrarka0 commented Apr 6, 2024

probable solution (not tested yet) to the issue is:

    def end(self, signum, frame):
        if not self.running:
            return
        logger.info("CTRL+C Detected! Please wait just a moment!")

@Petrarka0
Copy link
Author

yep solution is working

@rdavydov
Copy link
Owner

Then PR is welcome!

@rdavydov rdavydov self-assigned this Apr 11, 2024
@rdavydov rdavydov added 🐜 bug Something isn't working 🧱 enhancement New feature or request labels Apr 11, 2024
Petrarka0 added a commit to Petrarka0/Twitch-Channel-Points-Miner-v2 that referenced this issue Apr 11, 2024
Petrarka0 added a commit to Petrarka0/Twitch-Channel-Points-Miner-v2 that referenced this issue Apr 11, 2024
@Petrarka0 Petrarka0 linked a pull request Apr 11, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐜 bug Something isn't working 🧱 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants