Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix request timeout handling in parser.js #264

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix request timeout handling in parser.js #264

wants to merge 6 commits into from

Conversation

goldsrc
Copy link

@goldsrc goldsrc commented Jan 25, 2024 •
edited

fixes #238
Memory leak caused by not disposing of the TLS socket in case of timeout.

@goldsrc goldsrc mentioned this pull request Jan 25, 2024
Open
rbren
rbren reviewed Feb 12, 2024
View reviewed changes
lib/parser.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbren rbren rbren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Socket remains open after a timeout
2 participants
@goldsrc @rbren