Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing http & https web request library dependencies #222

Open
gaodeng opened this issue Dec 17, 2021 · 2 comments
Open

Removing http & https web request library dependencies #222

gaodeng opened this issue Dec 17, 2021 · 2 comments

Comments

@gaodeng
Copy link
Contributor

gaodeng commented Dec 17, 2021

Most projects using this library should already have their own network request library, so there doesn't seem to be much need to add the parseURL API. I suggest removing this method to remove the web request library dependency

@rbren
Copy link
Owner

rbren commented Jan 14, 2022

This seems like a good idea to me. The HTTP logic has caused a lot of issues.

@eviltik
Copy link

eviltik commented Jul 12, 2022

#228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants