Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running interpreter on an experiment should set this._inExperiment = true if no return is run #79

Open
dobesv opened this issue Jan 25, 2020 · 2 comments

Comments

@dobesv
Copy link

dobesv commented Jan 25, 2020

I believe the PlanOut language expects that if you don't return false then the experiment is considered active.

Currently the interpreter only sets _inExperiment = true if you explicitly return true in the script.

@rawls238
Copy link
Owner

Seems reasonable, feel free to PR

@eytan
Copy link
Contributor

eytan commented Jan 25, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants