Dictionary inconsistencies between store and patch for enum keys

[loraderon]

Edit
Store always uses string keys and patch always uses integer keys no matter if SaveEnumsAsIntegers is specified or not.

---

Store does not store enums as integers for dictionary keys when SaveEnumsAsIntegers is specified.

However, Patch seems to use integrers for dictionary keys which results in inconsistent data.

Test case

void Main()
{
	//Raven.Embedded.EmbeddedServer.Instance.StartServer();
	using var store = Raven.Embedded.EmbeddedServer.Instance
		.GetDocumentStore(new Raven.Embedded.DatabaseOptions("db")
		{
			Conventions = new()
			{
				SaveEnumsAsIntegers = true,
			},
		});
	store.Initialize();

	using var session = store.OpenSession();
	var foo = new Foo
	{
		Days = {
			{ DayOfWeek.Monday, "monday-store" },
		}
	};

	session.Store(foo);
	session.SaveChanges();

	session.Advanced.Patch<Foo, string>(foo.Id, f => f.Days[DayOfWeek.Monday], "monday-patch");
	session.SaveChanges();

	Raven.Embedded.EmbeddedServer.Instance.OpenStudioInBrowser();
}

public class Foo
{
	public string Id { get; set; }

	public Dictionary<DayOfWeek, string> Days { get; set; } = new();
}

Results

[ppekrol]

We will take a look. Meanwhile as a workaround you could write your own JsonConverter for that type that contains dictionary.
https://issues.hibernatingrhinos.com/issue/RavenDB-22084/Dictionary-inconsistencies-between-store-and-patch-when-specifying-SaveEnumsAsIntegers
Custom converters (we are using JSON.NET for serialization), can be registered via DocumentConventions.Serialization.CustomizeJsonSerializer (and Deserializer) methods: https://ravendb.net/docs/article-page/6.0/csharp/client-api/configuration/serialization#customizejsonserializer

[loraderon]

I also noticed that the enums are not unique even after reduce.

Edit:
Since it affects all enums (not only dictaionry keys) I started a discussion about it #18439

---

This index groups the results by day and spits out all the values.

public class FooIndex : AbstractIndexCreationTask<Foo, FooIndex.Result>
{
	public FooIndex()
	{
		Map = foos =>
			from f in foos
			from day in f.Days
			select new Result
			{
				Day = day.Key,
				Values = new[] { day.Value},
			};
		
		Reduce = results =>
			from result in results
			group result by new { result.Day } into g
			select new Result
			{
				Day = g.Key.Day,
				Values = g.SelectMany(x => x.Values).ToArray()
			};
	}
	
	public class Result
	{
		public DayOfWeek Day { get; set; }
		public string[] Values { get; set; }
	}
}

[ayende]

For reference, the issue is different: #18439

[loraderon]

I just noticed that the value of SaveEnumsAsIntegers does not matter at all. Dictionary enum keys are always stored as strings and patched as integers.

public class DictionaryEnumKeysTests : RavenTestDriver
{
    [Fact]
    public void DictionaryEnumKeys()
    {
        using var store = GetDocumentStore();

        using (var session = store.OpenSession())
        {
            var foo = new FooDictionaryEnum
            {
                Days = new() { { DayOfWeek.Monday, "monday-store" } },
            };
            session.Store(foo);

            session.SaveChanges();

            session.Advanced.Patch<FooDictionaryEnum, string>(foo.Id.ToString(), f => f.Days[DayOfWeek.Monday], "monday-patched");

            session.SaveChanges();
        }

        OpenBrowser(store.Urls.First());
        WaitForUserToContinueTheTest(store);
    }

    public class FooDictionaryEnum
    {
        public string Id { get; set; }
        public Dictionary<DayOfWeek, string> Days { get; set; }
    }
}