Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show current location #2

Open
derhuerst opened this issue Apr 26, 2017 · 7 comments · May be fixed by #12
Open

show current location #2

derhuerst opened this issue Apr 26, 2017 · 7 comments · May be fixed by #12

Comments

@derhuerst
Copy link
Contributor

Would like to be able to center the map around my current location. I wrote location for this.

Will submit a PR if you don't mind.

@rastapasta
Copy link
Owner

rastapasta commented Apr 26, 2017

lovely idea!

@derhuerst
Copy link
Contributor Author

derhuerst commented Apr 26, 2017

would you like to have a specific key to query the location? what about showing a progress indicator? what about setting the zoom level?

@derhuerst
Copy link
Contributor Author

@rastapasta
Copy link
Owner

would you like to have a specific key to query the location?

like the idea, choose any one that feels good for you :)

what about showing a progress indicator?

👍 _notify will help
would love to include a simple UI at some point to display information like progress/meta/search/*

what about setting the zoom level?

hum..., maybe on initial load keeping the minimal zoom, when pressing the corresponding key street/block-level-ish?

thanks for your work!

@derhuerst
Copy link
Contributor Author

would you like to have a specific key to query the location?

like the idea, choose any one that feels good for you :)

i picked l

current-location will show a notification now.

@derhuerst derhuerst linked a pull request Apr 29, 2017 that will close this issue
@rastapasta
Copy link
Owner

❤️ tried and works beautifully!

just one question came to my mind:
in terms of user control & privacy, should we maybe ask before sending the related data?

we could / i would implement a small info-footer with all keys on startup - with [l] being the first.

thoughts?

@derhuerst
Copy link
Contributor Author

in terms of user control & privacy, should we maybe ask before sending the related data?

good point. macOS will automatically ask if the helper tool (that location uses underneath) should be able to access your location. on Linux and Windows, this warning is currently missing.

from the perspective of location, we have two choices:

  • let consuming tools such as mapscii ask for permission. this is easy to implement, as the prompt can be shown in the best context possible (web, cli, gui)
  • let location ask for permission. this would have the advantage that we can use native system prompts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants