Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 10 typo #89

Open
rickiepark opened this issue Dec 2, 2018 · 3 comments
Open

Chapter 10 typo #89

rickiepark opened this issue Dec 2, 2018 · 3 comments
Labels
fixed-in-3rd-edition Tagged as fixed in the upcoming 3rd edition

Comments

@rickiepark
Copy link

(p326) In a paragraph below code block, "Using the 'absolute_loss' as an argument for the residual_metric" should be "Using the 'absolute_loss' as an argument for the loss".

@rickiepark
Copy link
Author

(p315) In code sns.pairplot(df[cols], size=2.5), size param is changed to height.

(p324) 1st paragraph is not false but readers may misunderstand that LinearRegression class use LIBLINEAR because the following code use LinearRegression class. As you know this class use scipy.linalg.lstsq function. It would be better to clarify usage of LIBLINEAR.

(p338) Maybe .f(x)=2^{-x} means f(x)=e^{-x}.

@rickiepark
Copy link
Author

(p314) in the last line of Note box,
df = pd.read_csv('./housing.data.txt'), sep='\s+')
should be
df = pd.read_csv('./housing.data.txt', sep='\s+')

@rasbt
Copy link
Owner

rasbt commented Jun 16, 2019

Thanks again for all your useful comments. I really appreciate it, and I agree with all your points.

(p326) In a paragraph below code block, "Using the 'absolute_loss' as an argument for the residual_metric" should be "Using the 'absolute_loss' as an argument for the loss".

Oh yes, not sure why I wrote residual_metric

(p315) In code sns.pairplot(df[cols], size=2.5), size param is changed to height.

Not using seaborn in the 3rd edition anymore (in favor of just matplotlib) so that issue should go away.

(p324) 1st paragraph is not false but readers may misunderstand that LinearRegression class use LIBLINEAR because the following code use LinearRegression class. As you know this class use scipy.linalg.lstsq function. It would be better to clarify usage of LIBLINEAR.

Good point. I think I was conflating that with the Lasso and Ridge implementations

(p338) Maybe .f(x)=2^{-x} means f(x)=e^{-x}.

Absolutely!

(p314) in the last line of Note box, ...

Good catch!

@rasbt rasbt added the fixed-in-3rd-edition Tagged as fixed in the upcoming 3rd edition label Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-in-3rd-edition Tagged as fixed in the upcoming 3rd edition
Projects
None yet
Development

No branches or pull requests

2 participants