Add validation of Rule fields

[dweiss]

No description provided.

[puntogil]

Hi,
sorry for the noise ...
the problem is related to
org.junit.internal.runners.rules.ValidationError: The @Rule 'ruleChain' must not be static or it must be annotated with @ClassRule.
?

and these test fails with randomizedtesting 2.3.1 (i haven't yet guava 19):
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestClassMethodFiltering.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestContextRandom.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestCustomMethodProvider.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestExpected.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestFailurePropagationCompatibility.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestFilteringWarnings.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestIgnoredRunCount.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestJ9SysThreads.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestListenersAnnotation.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestMacSysThreads.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestNightlyMode.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestOutOfScopeRandomUse.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestOverridingDefaultExceptionHandler.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestParameterized.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestParameterizedShufflesOrder.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestRepeatTestWithComplexDescription.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestResourceDisposal.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestRules.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestSeedDecorator.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestSeedFixingWithProperties.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestSeedParameterOptional.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestStackAugmentation.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestTargetMethod.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestTestFiltering.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestTestCaseInstanceProviders.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestTestCaseOrdering.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestTestGroups.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestUncaughtExceptionsDuplicated.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/TestValidation.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/contracts
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/rules
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/timeouts/Test001TimeoutSuite.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/timeouts/Test002TimeoutMethod.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/timeouts/Test003ThreadLeaksMethod.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/timeouts/Test004ThreadLeaksSuite.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/timeouts/Test005ThreadLeaksSystemThreads.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/timeouts/Test006TimeoutAndThreadLeak.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/timeouts/Test007UncaughtExceptions.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/timeouts/Test008SeedsAnnotation.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/timeouts/Test009TimeoutOrNotIdenticalSequence.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/timeouts/Test010Zombies.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/timeouts/Test013ThreadLeaksScopeNone.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/timeouts/Test014Timeout.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/timeouts/Test015TimeoutOverride.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/timeouts/Test016ThreadLeaksCustomFilters.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/timeouts/Test017ThreadLeaksCustomFiltersException.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/timeouts/Test018TimeoutStacks.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/timeouts/Test019ThreadLeakGroup.java
randomized-runner/src/test/java/com/carrotsearch/randomizedtesting/timeouts/Test020SuiteTimeoutStopsTests.java

Emviroment:
Apache Maven 3.3.3 (NON-CANONICAL_2015-07-10T12:37:52_mockbuild; 2015-07-10T14:37:52+02:00)
Maven home: /usr/share/maven
Java version: 1.8.0_71, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.71-1.b15.fc23.i386/jre
Default locale: it_IT, platform encoding: UTF-8
OS name: "linux", version: "4.3.3-301.fc23.i686", arch: "i386", family: "unix"
Used:

• junit 4.12
• guava 18.0
• ant 1.9.6

[dweiss]

Hmm.. not sure what you're reporting. I just ran all the tests and they passed on master branch?

[puntogil]

No, never tried
Thanks

[puntogil]

"maybe" is related to junit-team/junit4#793