Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non Issue - Just a Suggestion #32

Open
RaulEstaka opened this issue Feb 7, 2022 · 1 comment
Open

Non Issue - Just a Suggestion #32

RaulEstaka opened this issue Feb 7, 2022 · 1 comment

Comments

@RaulEstaka
Copy link

First off, thanks for creating and releasing this very helpful Package, it saved me a lot of time from coding it on my own for my quick project.

The only suggestion I have is in reference to the formatting of the return value for 'description'
What gets returned to me is not a description of the article but a series of short titles from other news sites, without links.
I know you are running it through BeautifulSoup which removes the links and the list structure and what is left is a confusing mess.

I modified the code so that I get back everything I want, but for other users you may want to add an option to switch that on and off. I added this to my base and control it during initialization of GNews, now I switch formatting by BeautifulSoup on/off with a simple option I pass once anytime it's needed. Considering most consumers of your API are technical this will not be confusing.

@ranahaani
Copy link
Owner

Great, can you please push the code and create a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants