0
@@ -1,5 +1,7 @@
0
 *SVN*
0
 
0
+* Fixed that single quote was not escaped in a UrlHelper#link_to javascript confirm #549 [Scott Barron]
0
+
0
 * Removed the default border on link_image_to (it broke xhtml strict) -- can be specified with :border => 0 #517 [?/caleb]
0
 
0
 * Fixed that form helpers would treat string and symbol keys differently in html_options (and possibly create duplicate entries) #112 [bitsweat]

0
@@ -138,7 +138,7 @@ module ActionView
0
       private
0
         def convert_confirm_option_to_javascript!(html_options)
0
           if confirm = html_options.delete("confirm")
0
-            html_options["onclick"] = "return confirm('#{confirm}');"
0
+            html_options["onclick"] = "return confirm('#{confirm.gsub(/'/, '\\\\\'')}');"
0
           end
0
         end
0
     end

0
@@ -27,6 +27,10 @@ class UrlHelperTest < Test::Unit::TestCase
0
       "<a href=\"http://www.world.com\" onclick=\"return confirm('Are you sure?');\">Hello</a>",
0
       link_to("Hello", "http://www.world.com", :confirm => "Are you sure?")
0
     )
0
+    assert_equal(
0
+      "<a href=\"http://www.world.com\" onclick=\"return confirm('You can\\'t possibly be sure, can you?');\">Hello</a>", 
0
+      link_to("Hello", "http://www.world.com", :confirm => "You can't possibly be sure, can you?")
0
+    )
0
   end
0
 
0
   def test_link_image_to