Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor the image credits styles in old blog posts #289

Open
alicetragedy opened this issue Aug 29, 2016 · 10 comments
Open

refactor the image credits styles in old blog posts #289

alicetragedy opened this issue Aug 29, 2016 · 10 comments

Comments

@alicetragedy
Copy link
Member

alicetragedy commented Aug 29, 2016

In one of the last contributions to the blog, the inline styling we use for image credits/descriptions was moved to its own class in a css file. Since we'll be sticking to that convention in the future (to have as little code in the single post files as possible) I'd like to fix all of the past posts as well to use that same convention.

@frefell
Copy link
Contributor

frefell commented Aug 15, 2017

is this still relevant? If yes, could you provide a little more context or which posts this would apply to? I'm just beginning but would like to help :)

@v-thakkar
Copy link
Member

Hi @frefell . Thanks for your interest. This is still relevant. The issue here is we have old posts which are not using image-credits style. You can check 2015 and 2014 posts. And for example you can check 2017 posts which are using image-credit style. I think you can start with picking the file -> 2015-10-30-cocoagems-get-strange-at-strangeloop.md.

@frefell
Copy link
Contributor

frefell commented Aug 15, 2017

Thanks for clarifying. I will start with 2015 then :)

frefell added a commit to frefell/summer-of-code that referenced this issue Aug 15, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 15, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 15, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 15, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 15, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 15, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 15, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 15, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 15, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 15, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 15, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 15, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 15, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 15, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 15, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 15, 2017
Caro-Lin added a commit to Caro-Lin/summer-of-code that referenced this issue Aug 15, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 15, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 15, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 29, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 29, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 29, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 29, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 29, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 29, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 29, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 29, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 29, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 29, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 29, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 29, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 29, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 29, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 29, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 29, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 29, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 29, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 31, 2017
frefell added a commit to frefell/summer-of-code that referenced this issue Aug 31, 2017
alicetragedy added a commit that referenced this issue Sep 1, 2017
@mkalininait
Copy link
Member

Fixed blog posts of 2017 (273a9c5)

@alicetragedy
Copy link
Member Author

thank you @mkalininait ! \o/

@MasonHolland
Copy link

@alicetragedy are the only pieces remaining on this the 2016 posts?

@alicetragedy
Copy link
Member Author

@MasonHolland yes, I think so! I'd probably have to double-check to make sure that nothing else is missing, but please don't let that stop you from contributing :) If you're interested in cleaning up the 2016, go ahead — in the meanwhile I'll take a look at what we have so far and if there's any older posts we might have missed.

@alicetragedy
Copy link
Member Author

@MasonHolland just wondering — are you interested in working on this issue? Is there anything I can do to help?

@wiseemily88
Copy link
Contributor

@alicetragedy- Hi! I’m a first-time contributor and was hoping to help out with this issue & I noticed in the comments that @MasonHolland is working on it. I'd love to help, and wanted to check in on the current status for this issue. Is there currently a solution in progress?

@alicetragedy
Copy link
Member Author

hej @wiseemily88 — thank you so much for your interest in helping out 💖I haven't heard anything back from @MasonHolland so my suggestion would be that you just go ahead and pick up this issue, if you want to work on it.
I believe the 2016 posts are the only ones left; let me know if you need any guidelines on getting started or if you get stuck or need clarifications on the task — I'm always happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants