Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI tests fail with pytest 8.0.0 #262

Closed
ljgray opened this issue Jan 29, 2024 · 1 comment
Closed

CI tests fail with pytest 8.0.0 #262

ljgray opened this issue Jan 29, 2024 · 1 comment
Assignees

Comments

@ljgray
Copy link
Contributor

ljgray commented Jan 29, 2024

Pytest 8.0.0 was released within the last week, along with pluggy 1.4.0. It now warns about old-style hook wrappers, causing our tests to fail with some fairly cryptic messages. See pytest-dev/pluggy#463

Pytest Release Notes: https://docs.pytest.org/en/stable/changelog.html
Pluggy docs: https://pluggy.readthedocs.io/en/stable/index.html#wrappers
Pluggy Release Notes: https://pluggy.readthedocs.io/en/stable/changelog.html#features

The issues are coming from pytest-dev/pluggy#463 but I'm not yet sure about whether there's a fix needed on our end or if we should be waiting on a new pytest release.

For the time being, I've pinned pytest < 8.0.0 and pluggy < 1.4.0 in #261

@ljgray ljgray changed the title CI tests fail with pluggy 1.4.0 due to https://github.com/pytest-dev/pluggy/issues/463 CI tests fail with pluggy 1.4.0 Jan 29, 2024
@ljgray ljgray self-assigned this Jan 29, 2024
@ljgray ljgray changed the title CI tests fail with pluggy 1.4.0 CI tests fail with pytest 8.0.0 Jan 29, 2024
@jrs65
Copy link
Contributor

jrs65 commented Feb 6, 2024

Fixed in #253 by replacing pytest-lazy-fixture with pytest-lazy-fixtures following suggestion in TvoroG/pytest-lazy-fixture#65 (comment)

@jrs65 jrs65 closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants