Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Schema version #1193

Open
m-mohr opened this issue Oct 25, 2022 · 5 comments
Open

JSON Schema version #1193

m-mohr opened this issue Oct 25, 2022 · 5 comments
Milestone

Comments

@m-mohr
Copy link
Collaborator

m-mohr commented Oct 25, 2022

At some point we should update the JSON Schemas from the 2018 draft-7 to a more recent version (so the successor of 2020-12).
Great benefit we'd get from the upcoming version, which supports object-based contains (see json-schema-org/json-schema-spec#1077 ) which would be very useful to validate assets.

Once available, we'd need to update and extend all schemas (major work) and also wait for tooling support in the JSON Schema libraries.

@m-mohr m-mohr added this to the future milestone Oct 25, 2022
@philvarner
Copy link
Collaborator

Related to this is

Why do all of the $id fields have an empty anchor at the end?

"$id": "https://schemas.stacspec.org/v1.0.0/item-spec/json-schema/item.json#",

@m-mohr
Copy link
Collaborator Author

m-mohr commented Mar 23, 2023

For no specific reason, I guess. Maybe because the $schema also has it? Must probably also be changed for all extensions? PRs are welcome...

@philvarner
Copy link
Collaborator

It looks like newer versions of the JSON Schema spec have dropped the trailing # in their $id value.

Do you think changing this would require a v1.0.1 release of the core specs? It doesn't actually change anything about the specs and the URL resolves the same in practice, so I'm not certain it would.

@m-mohr
Copy link
Collaborator Author

m-mohr commented Mar 23, 2023

As it's allowed in draft-7 I don't think we are in a rush and can just update it in the next release, right?

@philvarner
Copy link
Collaborator

I was planning ahead in case it wasn't or jsonschema decides not to support in >=1.18.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants