Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

m_lastLapTime vs m_lastLapTimeInMS typing mismatch #72

Open
iamisti opened this issue Oct 13, 2021 · 2 comments
Open

m_lastLapTime vs m_lastLapTimeInMS typing mismatch #72

iamisti opened this issue Oct 13, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@iamisti
Copy link

iamisti commented Oct 13, 2021

Hi guys!
Please adjust the typescript definitions for the 2021 game.
m_lastLapTimeInMS and m_currentLapTimeInMS, and potentionally others needs also an alignment.
At the moment m_lastLapTime is in the typings which is wrong.

@jonybur
@iamisti iamisti added the bug Something isn't working label Oct 13, 2021
@iamisti
Copy link
Author

iamisti commented Oct 13, 2021

actually the best way would be to list both, since 2021 and 2020 telemtry differs. So that we developers can choose.

@msansoni msansoni mentioned this issue Nov 30, 2022
Closed
@msansoni
Copy link
Contributor

Would love to accept a PR on this, there's a greater topic of splitting more of the parsing logic in to separate files for each game year as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iamisti @msansoni